)]}'
{"tests/unit/test_launcher.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"708044492f1ff0f028ea2463fbef183b3e634bf6","unresolved":true,"context_lines":[{"line_number":4199,"context_line":"            if sub1.request_id and sub2.request_id:"},{"line_number":4200,"context_line":"                break"},{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        self.assertNotEqual(sub1.request_id, sub2.request_id)"},{"line_number":4203,"context_line":"        cache._event_queue.unpause()"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"    @simple_layout(\u0027layouts/nodepool-reuse.yaml\u0027, enable_nodepool\u003dTrue)"},{"line_number":4206,"context_line":"    def test_reuse(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b10ae178_458dc79a","line":4203,"range":{"start_line":4202,"start_character":0,"end_line":4203,"end_character":36},"updated":"2026-07-18 13:37:29.000000000","message":"nit, Should use finally block or or addCleanup(cache._event_queue.unpause) for the unpause? If the assert fails the queue stays paused even after ZuulTestCase.shutdown()","commit_id":"3fa3bae530d816697785a117035a68c85b893042"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1baf19766c064137d6f61a53a26d1326bee5ff0e","unresolved":false,"context_lines":[{"line_number":4200,"context_line":"                break"},{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        self.assertNotEqual(sub1.request_id, sub2.request_id)"},{"line_number":4203,"context_line":"        cache._event_queue.unpause()"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"    @simple_layout(\u0027layouts/nodepool-reuse.yaml\u0027, enable_nodepool\u003dTrue)"},{"line_number":4206,"context_line":"    def test_reuse(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9d65272_bbfaba41","line":4203,"in_reply_to":"b10ae178_458dc79a","updated":"2026-07-28 15:45:25.000000000","message":"The test still finishes without hanging in that case.","commit_id":"3fa3bae530d816697785a117035a68c85b893042"}],"zuul/launcher/server.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"506c863e0c001055a7a3e60fb90895032790b791","unresolved":true,"context_lines":[{"line_number":1816,"context_line":"            self.system.system_id, label, node_uuid, request)"},{"line_number":1817,"context_line":"        node_class \u003d provider.driver.getProviderNodeClass()"},{"line_number":1818,"context_line":"        node \u003d node_class.new(ctx, **args)"},{"line_number":1819,"context_line":"        self.api.nodes_cache.insert(node)"},{"line_number":1820,"context_line":"        log.debug(\"Requested node %s\", node)"},{"line_number":1821,"context_line":"        retnode \u003d node"},{"line_number":1822,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a5443379_a4fd8dae","line":1819,"range":{"start_line":1819,"start_character":8,"end_line":1819,"end_character":41},"updated":"2026-07-17 08:12:57.000000000","message":"I think we should use the return value: `node \u003d self.api.nodes_cache.insert(node)`","commit_id":"cd370ccc9138b319151f523becbbd572cff39e53"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"adf3f855e363989ebc2e7826086ada0e7538d8f8","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"            self.system.system_id, label, node_uuid, request)"},{"line_number":1817,"context_line":"        node_class \u003d provider.driver.getProviderNodeClass()"},{"line_number":1818,"context_line":"        node \u003d node_class.new(ctx, **args)"},{"line_number":1819,"context_line":"        self.api.nodes_cache.insert(node)"},{"line_number":1820,"context_line":"        log.debug(\"Requested node %s\", node)"},{"line_number":1821,"context_line":"        retnode \u003d node"},{"line_number":1822,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"498c073d_dc6d90d8","line":1819,"in_reply_to":"a5443379_a4fd8dae","updated":"2026-07-17 13:56:25.000000000","message":"Yep!","commit_id":"cd370ccc9138b319151f523becbbd572cff39e53"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"506c863e0c001055a7a3e60fb90895032790b791","unresolved":true,"context_lines":[{"line_number":1855,"context_line":"            create_state_machine\u003dSubnodeStateMachine(),"},{"line_number":1856,"context_line":"            **args,"},{"line_number":1857,"context_line":"        )"},{"line_number":1858,"context_line":"        self.api.nodes_cache.insert(subnode)"},{"line_number":1859,"context_line":"        return subnode"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def _checkRequest(self, request, log, unassigned_nodes):"},{"line_number":1862,"context_line":"        messages \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6e97aba_04401d3d","line":1859,"range":{"start_line":1858,"start_character":0,"end_line":1859,"end_character":22},"updated":"2026-07-17 08:12:57.000000000","message":"We should also return the subnode from `insert()` here.","commit_id":"cd370ccc9138b319151f523becbbd572cff39e53"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"adf3f855e363989ebc2e7826086ada0e7538d8f8","unresolved":false,"context_lines":[{"line_number":1856,"context_line":"            **args,"},{"line_number":1857,"context_line":"        )"},{"line_number":1858,"context_line":"        self.api.nodes_cache.insert(subnode)"},{"line_number":1859,"context_line":"        return subnode"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def _checkRequest(self, request, log, unassigned_nodes):"},{"line_number":1862,"context_line":"        messages \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f6e8f44_95165341","line":1859,"in_reply_to":"c6e97aba_04401d3d","updated":"2026-07-17 13:56:25.000000000","message":"Done.","commit_id":"cd370ccc9138b319151f523becbbd572cff39e53"}]}